[Supplier] Updating the scaffolded Claim type
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_id root_hash --no-message --yes
Olshansk
changed the title
Claim type
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Co-authored-by: harry <[email protected]>
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * fix: flakey test * chore: dial back godoc comments 😅 * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: review feedback improvements * docs: update client README.md * docs: add `tx query` usage association between `txContext` & `Blockchain` * docs: add TOC * chore: review feedback improvements Co-authored-by: Daniel Olshansky <[email protected]> * docs: improve godoc comments & client README.md --------- Co-authored-by: Daniel Olshansky <[email protected]>
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * refactor: consolidate keyring errors & helpers * refactor: keyring test helpers * fix: flakey test * chore: dial back godoc comments 😅 * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update
* chore: add `TxClient` interface * chore: add option support to `ReplayObservable` * feat: add `txClient` implementation * test: `txClient` * test: tx client integration * chore: s/tx/transaction/g * chore: update pkg README.md template * wip: client pkg README * docs: fix client pkg godoc comment * refactor: consolidate keyring errors & helpers * refactor: keyring test helpers * fix: flakey test * chore: dial back godoc comments 😅 * chore: add `SupplierClient` interface * feat: add supplier client implementation * test: supplier test helpers * test: supplier client tests * test: supplier client integration test * chore: update go.mod * trigger CI * chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment * chore: update go.mod * chore: refactor & condense godoc comments * chore: fix import paths post-update * chore: add godoc comment
…ocs (#153) * refactor: move /internal pkgs to /testutil * chore: cleanup
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@bryanchriswhite @h5law Note that this is still a draft because I left 4 |
|
I still have a few finishing touches on this PR but marking it as ready for review in parallel |
h5law
reviewed
Nov 16, 2023
h5law
reviewed
Nov 16, 2023
h5law
reviewed
Nov 16, 2023
| var resp types.QueryAllClaimsResponse | ||
| require.NoError(t, net.Config.Codec.UnmarshalJSON(out.Bytes(), &resp)) | ||
|
|
||
| require.Equal(t, numSessions, int(resp.Pagination.Total)) | ||
| // require.ElementsMatch(t, |
There was a problem hiding this comment.
It's not, but ty for the reminder. Just added these back in!
h5law
reviewed
Nov 16, 2023
h5law
reviewed
Nov 16, 2023
6 tasks
8 tasks
8 tasks
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
- Removed `Claim`s from the genesis file - Indexing Claims by height & address in addition to its primary composite key upon insertion - Added the ability to query claims by `session-id`, `session-end-height` and `supplier address` - Added some `claim` makefile helpers to create and view them --------- Co-authored-by: Bryan White <[email protected]> Co-authored-by: harry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: DO NOT REVIEW THE
_test.gofiles yet. they're not readySummary
Human Summary
Claims from the genesis filesession-id,session-end-heightandsupplier addressclaimmakefile helpers to create and view themIssue
Issue:
CreateClaimmessage handling #140Claimtype #149Type of change
Select one or more:
Testing
make go_develop_and_testSanity Checklist